1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
#[cfg(feature = "parallel")]
use std::iter::repeat;
use std::{
cell::UnsafeCell,
fmt::{Debug, Formatter},
};
#[cfg(feature = "parallel")]
use std::{
collections::{HashMap, HashSet},
sync::atomic::{AtomicUsize, Ordering},
};
#[cfg(feature = "parallel")]
use itertools::izip;
#[cfg(feature = "parallel")]
use rayon::prelude::*;
use super::{
command::CommandBuffer,
resources::{ResourceTypeId, Resources, UnsafeResources},
system::SystemId,
};
use crate::internals::{
storage::component::ComponentTypeId,
subworld::ArchetypeAccess,
world::{World, WorldId},
};
pub trait ParallelRunnable: Runnable + Send + Sync {}
impl<T: Runnable + Send + Sync> ParallelRunnable for T {}
impl Debug for dyn ParallelRunnable {
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), std::fmt::Error> {
Debug::fmt(&self.name(), f)
}
}
pub trait Runnable {
fn name(&self) -> Option<&SystemId>;
fn reads(&self) -> (&[ResourceTypeId], &[ComponentTypeId]);
fn writes(&self) -> (&[ResourceTypeId], &[ComponentTypeId]);
fn prepare(&mut self, world: &World);
fn accesses_archetypes(&self) -> &ArchetypeAccess;
unsafe fn run_unsafe(&mut self, world: &World, resources: &UnsafeResources);
fn command_buffer_mut(&mut self, world: WorldId) -> Option<&mut CommandBuffer>;
fn run(&mut self, world: &mut World, resources: &mut Resources) {
unsafe { self.run_unsafe(world, resources.internal()) };
}
}
impl Debug for dyn Runnable {
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), std::fmt::Error> {
Debug::fmt(&self.name(), f)
}
}
#[derive(Debug)]
pub struct Executor {
systems: Vec<SystemBox>,
#[cfg(feature = "parallel")]
static_dependants: Vec<Vec<usize>>,
#[cfg(feature = "parallel")]
dynamic_dependants: Vec<Vec<usize>>,
#[cfg(feature = "parallel")]
static_dependency_counts: Vec<AtomicUsize>,
#[cfg(feature = "parallel")]
awaiting: Vec<AtomicUsize>,
}
struct SystemBox(UnsafeCell<Box<dyn ParallelRunnable>>);
unsafe impl Send for SystemBox {}
unsafe impl Sync for SystemBox {}
impl SystemBox {
unsafe fn get(&self) -> &dyn ParallelRunnable {
std::ops::Deref::deref(&*self.0.get())
}
#[allow(clippy::mut_from_ref)]
unsafe fn get_mut(&self) -> &mut dyn ParallelRunnable {
std::ops::DerefMut::deref_mut(&mut *self.0.get())
}
}
impl Debug for SystemBox {
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), std::fmt::Error> {
unsafe { Debug::fmt(&self.get().name(), f) }
}
}
impl Executor {
#[cfg(not(feature = "parallel"))]
pub fn new(systems: Vec<Box<dyn ParallelRunnable>>) -> Self {
Self {
systems: systems
.into_iter()
.map(|s| SystemBox(UnsafeCell::new(s)))
.collect(),
}
}
#[cfg(feature = "parallel")]
#[allow(clippy::cognitive_complexity)]
pub fn new(systems: Vec<Box<dyn ParallelRunnable>>) -> Self {
if systems.len() > 1 {
let mut static_dependency_counts = Vec::with_capacity(systems.len());
let mut static_dependants: Vec<Vec<_>> =
repeat(Vec::with_capacity(64)).take(systems.len()).collect();
let mut dynamic_dependants: Vec<Vec<_>> =
repeat(Vec::with_capacity(64)).take(systems.len()).collect();
#[derive(Default)]
struct PreviousAccess {
readers: Vec<usize>,
last_writer: Option<usize>,
}
impl PreviousAccess {
fn add_read(&mut self, idx: usize) -> Option<usize> {
self.readers.push(idx);
self.last_writer
}
fn add_write(&mut self, idx: usize) -> Vec<usize> {
let mut dependencies = Vec::new();
std::mem::swap(&mut self.readers, &mut dependencies);
if let Some(writer) = self.last_writer.replace(idx) {
dependencies.push(writer)
}
dependencies
}
}
let mut resource_accesses =
HashMap::<ResourceTypeId, PreviousAccess>::with_capacity_and_hasher(
64,
Default::default(),
);
let mut component_accesses =
HashMap::<ComponentTypeId, PreviousAccess>::with_capacity_and_hasher(
64,
Default::default(),
);
for (i, system) in systems.iter().enumerate() {
let (read_res, read_comp) = system.reads();
let (write_res, write_comp) = system.writes();
let mut dependencies = HashSet::with_capacity(64);
for res in read_res {
let access = resource_accesses.entry(*res).or_default();
if let Some(dep) = access.add_read(i) {
dependencies.insert(dep);
}
}
for res in write_res {
let access = resource_accesses.entry(*res).or_default();
for dep in access.add_write(i) {
dependencies.insert(dep);
}
}
static_dependency_counts.push(AtomicUsize::from(dependencies.len()));
for dep in &dependencies {
static_dependants[*dep].push(i);
}
let mut comp_dependencies = HashSet::<usize>::default();
for comp in read_comp {
let access = component_accesses.entry(*comp).or_default();
if let Some(dep) = access.add_read(i) {
comp_dependencies.insert(dep);
}
}
for comp in write_comp {
let access = component_accesses.entry(*comp).or_default();
for dep in access.add_write(i) {
comp_dependencies.insert(dep);
}
}
for static_dep in &dependencies {
comp_dependencies.remove(static_dep);
}
for dep in comp_dependencies {
if dep != i {
dynamic_dependants[dep].push(i);
}
}
}
let mut awaiting = Vec::with_capacity(systems.len());
systems
.iter()
.for_each(|_| awaiting.push(AtomicUsize::new(0)));
Executor {
awaiting,
static_dependants,
dynamic_dependants,
static_dependency_counts,
systems: systems
.into_iter()
.map(|s| SystemBox(UnsafeCell::new(s)))
.collect(),
}
} else {
Executor {
awaiting: Vec::with_capacity(0),
static_dependants: Vec::with_capacity(0),
dynamic_dependants: Vec::with_capacity(0),
static_dependency_counts: Vec::with_capacity(0),
systems: systems
.into_iter()
.map(|s| SystemBox(UnsafeCell::new(s)))
.collect(),
}
}
}
pub fn into_vec(self) -> Vec<Box<dyn ParallelRunnable>> {
self.systems.into_iter().map(|s| s.0.into_inner()).collect()
}
#[cfg(not(feature = "parallel"))]
pub fn execute(&mut self, world: &mut World, resources: &mut Resources) {
let unsafe_resources = resources.internal();
self.run_systems(world, unsafe_resources);
self.flush_command_buffers(world, resources);
}
#[cfg(feature = "parallel")]
pub fn execute(&mut self, world: &mut World, resources: &mut Resources) {
let unsafe_resources = resources.internal();
rayon::join(|| self.run_systems(world, unsafe_resources), || {});
self.flush_command_buffers(world, resources);
}
#[cfg(not(feature = "parallel"))]
pub fn run_systems(&mut self, world: &mut World, resources: &UnsafeResources) {
self.systems.iter_mut().for_each(|system| {
let system = unsafe { system.get_mut() };
system.prepare(world);
unsafe { system.run_unsafe(world, resources) };
});
}
#[cfg(feature = "parallel")]
pub fn run_systems(&mut self, world: &mut World, resources: &UnsafeResources) {
match self.systems.len() {
1 => {
unsafe {
let system = self.systems[0].get_mut();
system.prepare(world);
system.run_unsafe(world, resources);
};
}
_ => {
let systems = &mut self.systems;
let static_dependency_counts = &self.static_dependency_counts;
let awaiting = &mut self.awaiting;
systems
.par_iter_mut()
.for_each(|sys| unsafe { sys.get_mut() }.prepare(world));
izip!(
systems.iter(),
self.static_dependants.iter_mut(),
self.dynamic_dependants.iter_mut()
)
.par_bridge()
.for_each(|(sys, static_dep, dyn_dep)| {
let archetypes = unsafe { sys.get() }.accesses_archetypes();
for i in (0..dyn_dep.len()).rev() {
let dep = dyn_dep[i];
let other = unsafe { systems[dep].get() };
if !other.accesses_archetypes().is_disjoint(archetypes) {
static_dep.push(dep);
dyn_dep.swap_remove(i);
static_dependency_counts[dep].fetch_add(1, Ordering::Relaxed);
}
}
});
for (i, count) in static_dependency_counts.iter().enumerate() {
awaiting[i].store(count.load(Ordering::Relaxed), Ordering::Relaxed);
}
let awaiting = &self.awaiting;
(0..systems.len())
.into_par_iter()
.filter(|i| static_dependency_counts[*i].load(Ordering::SeqCst) == 0)
.for_each(|i| {
unsafe { self.run_recursive(i, world, resources) };
});
debug_assert!(
awaiting.iter().all(|x| x.load(Ordering::SeqCst) == 0),
"not all systems run: {:?}",
awaiting
);
}
}
}
pub fn flush_command_buffers(&mut self, world: &mut World, resources: &mut Resources) {
self.systems.iter().for_each(|system| {
let system = unsafe { system.get_mut() };
if let Some(cmd) = system.command_buffer_mut(world.id()) {
cmd.flush(world, resources);
}
});
}
#[cfg(feature = "parallel")]
unsafe fn run_recursive(&self, i: usize, world: &World, resources: &UnsafeResources) {
self.systems[i].get_mut().run_unsafe(world, resources);
self.static_dependants[i].par_iter().for_each(|dep| {
if self.awaiting[*dep].fetch_sub(1, Ordering::Relaxed) == 1 {
self.run_recursive(*dep, world, resources);
}
});
}
}
pub struct Builder {
steps: Vec<Step>,
accumulator: Vec<Box<dyn ParallelRunnable>>,
}
impl Builder {
pub fn add_system<T: ParallelRunnable + 'static>(&mut self, system: T) -> &mut Self {
self.accumulator.push(Box::new(system));
self
}
pub fn flush(&mut self) -> &mut Self {
self.finalize_executor();
self.steps.push(Step::FlushCmdBuffers);
self
}
fn finalize_executor(&mut self) {
if !self.accumulator.is_empty() {
let mut systems = Vec::new();
std::mem::swap(&mut self.accumulator, &mut systems);
let executor = Executor::new(systems);
self.steps.push(Step::Systems(executor));
}
}
pub fn add_thread_local_fn<F: FnMut(&mut World, &mut Resources) + 'static>(
&mut self,
f: F,
) -> &mut Self {
self.finalize_executor();
self.steps.push(Step::ThreadLocalFn(
Box::new(f) as Box<dyn FnMut(&mut World, &mut Resources)>
));
self
}
pub fn add_thread_local<S: Runnable + 'static>(&mut self, system: S) -> &mut Self {
self.finalize_executor();
let system = Box::new(system) as Box<dyn Runnable>;
self.steps.push(Step::ThreadLocalSystem(system));
self
}
pub fn build(&mut self) -> Schedule {
self.flush();
let mut steps = Vec::new();
std::mem::swap(&mut self.steps, &mut steps);
Schedule { steps }
}
}
impl Default for Builder {
fn default() -> Self {
Self {
steps: Vec::new(),
accumulator: Vec::new(),
}
}
}
pub enum Step {
Systems(Executor),
FlushCmdBuffers,
ThreadLocalFn(Box<dyn FnMut(&mut World, &mut Resources)>),
ThreadLocalSystem(Box<dyn Runnable>),
}
impl Debug for Step {
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), std::fmt::Error> {
match self {
Step::Systems(x) => f.debug_tuple("Systems").field(&x).finish(),
Step::FlushCmdBuffers => f.debug_tuple("FlushCmdBuffers").finish(),
Step::ThreadLocalFn(_) => {
f.debug_tuple("ThreadLocalFn")
.field(&"dyn FnMut(&mut World, &mut Resources)")
.finish()
}
Step::ThreadLocalSystem(x) => f.debug_tuple("ThreadLocalSystem").field(&x).finish(),
}
}
}
#[derive(Debug)]
pub struct Schedule {
steps: Vec<Step>,
}
impl Schedule {
pub fn builder() -> Builder {
Builder::default()
}
#[cfg(not(feature = "parallel"))]
pub fn execute(&mut self, world: &mut World, resources: &mut Resources) {
self.execute_internal(world, resources, |world, resources, executor| {
executor.run_systems(world, resources.internal())
});
}
#[cfg(feature = "parallel")]
pub fn execute(&mut self, world: &mut World, resources: &mut Resources) {
self.execute_internal(world, resources, |world, resources, executor| {
let resources = resources.internal();
rayon::join(|| executor.run_systems(world, resources), || {});
});
}
#[cfg(feature = "parallel")]
pub fn execute_in_thread_pool(
&mut self,
world: &mut World,
resources: &mut Resources,
pool: &rayon::ThreadPool,
) {
self.execute_internal(world, resources, |world, resources, executor| {
let resources = resources.internal();
pool.install(|| executor.run_systems(world, resources));
});
}
fn execute_internal<F: FnMut(&mut World, &mut Resources, &mut Executor)>(
&mut self,
world: &mut World,
resources: &mut Resources,
mut run_executor: F,
) {
enum ToFlush<'a> {
Executor(&'a mut Executor),
System(&'a mut CommandBuffer),
}
let mut waiting_flush: Vec<ToFlush> = Vec::new();
for step in &mut self.steps {
match step {
Step::Systems(executor) => {
run_executor(world, resources, executor);
waiting_flush.push(ToFlush::Executor(executor));
}
Step::FlushCmdBuffers => {
waiting_flush.drain(..).for_each(|e| {
match e {
ToFlush::Executor(exec) => exec.flush_command_buffers(world, resources),
ToFlush::System(cmd) => cmd.flush(world, resources),
}
});
}
Step::ThreadLocalFn(function) => function(world, resources),
Step::ThreadLocalSystem(system) => {
system.prepare(world);
system.run(world, resources);
if let Some(cmd) = system.command_buffer_mut(world.id()) {
waiting_flush.push(ToFlush::System(cmd));
}
}
}
}
}
pub fn into_vec(self) -> Vec<Step> {
self.steps
}
}
impl From<Builder> for Schedule {
fn from(mut builder: Builder) -> Self {
builder.build()
}
}
impl From<Vec<Step>> for Schedule {
fn from(steps: Vec<Step>) -> Self {
Self { steps }
}
}
#[cfg(test)]
mod tests {
use std::sync::{Arc, Mutex};
use itertools::sorted;
use super::*;
use crate::internals::{
query::{view::write::Write, IntoQuery},
systems::system::SystemBuilder,
};
#[test]
fn execute_in_order() {
let mut world = World::default();
#[derive(Default)]
struct Resource;
let mut resources = Resources::default();
resources.insert(Resource);
let order = Arc::new(Mutex::new(Vec::new()));
let order_clone = order.clone();
let system_one = SystemBuilder::new("one")
.write_resource::<Resource>()
.build(move |_, _, _, _| order_clone.lock().unwrap().push(1usize));
let order_clone = order.clone();
let system_two = SystemBuilder::new("two")
.write_resource::<Resource>()
.build(move |_, _, _, _| order_clone.lock().unwrap().push(2usize));
let order_clone = order.clone();
let system_three = SystemBuilder::new("three")
.write_resource::<Resource>()
.build(move |_, _, _, _| order_clone.lock().unwrap().push(3usize));
let mut schedule = Schedule::builder()
.add_system(system_one)
.add_system(system_two)
.add_system(system_three)
.build();
schedule.execute(&mut world, &mut resources);
let order = order.lock().unwrap();
let sorted: Vec<usize> = sorted(order.clone()).collect();
assert_eq!(*order, sorted);
}
#[test]
fn flush() {
let mut world = World::default();
let mut resources = Resources::default();
#[derive(Clone, Copy, Debug, PartialEq)]
struct TestComp(f32, f32, f32);
let system_one = SystemBuilder::new("one").build(move |cmd, _, _, _| {
cmd.push((TestComp(0., 0., 0.),));
});
let system_two = SystemBuilder::new("two")
.with_query(Write::<TestComp>::query())
.build(move |_, world, _, query| {
assert_eq!(0, query.iter_mut(world).count());
});
let system_three = SystemBuilder::new("three")
.with_query(Write::<TestComp>::query())
.build(move |_, world, _, query| {
assert_eq!(1, query.iter_mut(world).count());
});
let mut schedule = Schedule::builder()
.add_system(system_one)
.add_system(system_two)
.flush()
.add_system(system_three)
.build();
schedule.execute(&mut world, &mut resources);
}
#[test]
fn flush_thread_local() {
let mut world = World::default();
let mut resources = Resources::default();
#[derive(Clone, Copy, Debug, PartialEq)]
struct TestComp(f32, f32, f32);
let entity = Arc::new(Mutex::new(None));
{
let entity = entity.clone();
let system_one = SystemBuilder::new("one").build(move |cmd, _, _, _| {
let mut entity = entity.lock().unwrap();
*entity = Some(cmd.push((TestComp(0.0, 0.0, 0.0),)));
});
let mut schedule = Schedule::builder().add_thread_local(system_one).build();
schedule.execute(&mut world, &mut resources);
}
let entity = entity.lock().unwrap();
assert!(entity.is_some());
assert!(world.entry(entity.unwrap()).is_some());
}
#[test]
fn thread_local_resource() {
let mut world = World::default();
let mut resources = Resources::default();
#[derive(Clone, Copy, Debug, PartialEq)]
struct NotSync(*const u8);
resources.insert(NotSync(std::ptr::null()));
let system = SystemBuilder::new("one")
.read_resource::<NotSync>()
.build(move |_, _, _, _| {});
let mut schedule = Schedule::builder().add_thread_local(system).build();
schedule.execute(&mut world, &mut resources);
}
}